Skip to content

export fromDateToLocal #9548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
maximepvrt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

export fromDateToLocal #9548

maximepvrt wants to merge 1 commit into from
+1 −0

Conversation

@maximepvrt
Copy link

@maximepvrt maximepvrt commented Jan 28, 2026

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

snowystinger
snowystinger reviewed Jan 28, 2026
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We'll need to add a description jsdoc to the function and add it to our documentation as well, would you like to handle that?

You'll also need to sign the CLA

Please sign the Adobe CLA! Once signed, close and re-open your pull request to run the check again.

packages/@internationalized/date/src/index.ts
toTimeZone,
toLocalTimeZone,
fromDate,
fromDateToLocal,
Copy link
Member

@snowystinger snowystinger Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh... we don't use this function anywhere in our codebase, @devongovett what was the intent here?

Copy link
Author

@maximepvrt maximepvrt Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snowystinger I discovered this function while trying to use fromDate without a timezone. Is there a reason we didn’t just make the timezone optional and keep a single function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maximepvrt @snowystinger